Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add utoipa annotation for infra/{id}/switch_types #7370

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented May 3, 2024

Part of #4580

@hamz2a hamz2a requested review from a team as code owners May 3, 2024 16:51
@hamz2a hamz2a changed the title editoast: add utoipa annotation for infra/{id}/switch_types editoast: add utoipa annotation for infra/{id}/switch_types May 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.14%. Comparing base (6b648d8) to head (c149c1f).

Files Patch % Lines
...c/applications/editor/tools/switchEdition/types.ts 0.00% 2 Missing ⚠️
editoast/src/views/infra/mod.rs 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7370   +/-   ##
=========================================
  Coverage     29.14%   29.14%           
  Complexity     2016     2016           
=========================================
  Files          1141     1141           
  Lines        139977   139997   +20     
  Branches       2769     2769           
=========================================
+ Hits          40793    40802    +9     
- Misses        97568    97579   +11     
  Partials       1616     1616           
Flag Coverage Δ
core 76.29% <ø> (ø)
editoast 71.96% <90.90%> (-0.04%) ⬇️
front 9.37% <92.30%> (+0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and 🚀 , thanks!

editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-id-switch-types branch from fcf29ed to 1e97630 Compare May 6, 2024 09:23
@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-id-switch-types branch from 1e97630 to c149c1f Compare May 6, 2024 12:41
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hamz2a hamz2a added this pull request to the merge queue May 7, 2024
Merged via the queue into dev with commit e014172 May 7, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-utoipa-annotation-for-infra-id-switch-types branch May 7, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants