Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editoast search cache refresh query #7369

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

leovalais
Copy link
Contributor

Adds the ordered list of columns in the INSERT statements in case the real table columns do not follow the declaration order in objects.rs.

@leovalais leovalais requested a review from a team as a code owner May 3, 2024 13:10
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.59%. Comparing base (17a2dce) to head (e54dd33).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7369       +/-   ##
=============================================
- Coverage     29.14%   18.59%   -10.55%     
  Complexity     2016     2016               
=============================================
  Files          1141      887      -254     
  Lines        139966   112339    -27627     
  Branches       2769     2769               
=============================================
- Hits          40795    20894    -19901     
+ Misses        97555    89829     -7726     
  Partials       1616     1616               
Flag Coverage Δ
core 76.29% <ø> (-0.03%) ⬇️
editoast ?
front 9.36% <ø> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@leovalais leovalais added this pull request to the merge queue May 3, 2024
Merged via the queue into dev with commit 6b648d8 May 3, 2024
17 checks passed
@leovalais leovalais deleted the lva/fix-search-cache-refresh branch May 3, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants