Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix osrd error deserialisation due to missing unit and kotlin adapters #7355

Merged
merged 1 commit into from
May 2, 2024

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented May 2, 2024

No description provided.

@Erashin Erashin added the area:core Work on Core Service label May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.12%. Comparing base (e21379d) to head (62faa2c).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7355   +/-   ##
=========================================
  Coverage     29.11%   29.12%           
  Complexity     2020     2020           
=========================================
  Files          1138     1137    -1     
  Lines        139726   139698   -28     
  Branches       2757     2754    -3     
=========================================
+ Hits          40680    40681    +1     
+ Misses        97437    97408   -29     
  Partials       1609     1609           
Flag Coverage Δ
core 77.00% <100.00%> (+0.24%) ⬆️
editoast 72.01% <ø> (-0.03%) ⬇️
front 9.34% <ø> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin marked this pull request as ready for review May 2, 2024 07:26
@Erashin Erashin requested a review from a team as a code owner May 2, 2024 07:26
@Erashin Erashin requested a review from Khoyo May 2, 2024 07:26
@Erashin Erashin force-pushed the alch/fix_adapter_osrd_error branch from d250c64 to 62faa2c Compare May 2, 2024 07:48
@Erashin Erashin added this pull request to the merge queue May 2, 2024
@Erashin Erashin linked an issue May 2, 2024 that may be closed by this pull request
Merged via the queue into dev with commit ad43ff0 May 2, 2024
17 checks passed
@Erashin Erashin deleted the alch/fix_adapter_osrd_error branch May 2, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2: Add core conflict endpoint
3 participants