Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add utoipa annotation for infra/{id}/voltages #7344

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 30, 2024

Part of #4580

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.12%. Comparing base (113dbd9) to head (cb61aa0).
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/common/api/osrdEditoastApi.ts 81.25% 3 Missing ⚠️
.../rangeEdition/components/RangeEditionLeftPanel.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7344   +/-   ##
=========================================
  Coverage     29.11%   29.12%           
  Complexity     2020     2020           
=========================================
  Files          1138     1138           
  Lines        139734   139740    +6     
  Branches       2757     2757           
=========================================
+ Hits          40689    40695    +6     
  Misses        97436    97436           
  Partials       1609     1609           
Flag Coverage Δ
core 76.76% <ø> (ø)
editoast 72.06% <100.00%> (+<0.01%) ⬆️
front 9.34% <72.22%> (-0.01%) ⬇️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-id-voltages branch from fc32685 to cb61aa0 Compare May 2, 2024 07:42
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hamz2a hamz2a added this pull request to the merge queue May 2, 2024
Merged via the queue into dev with commit 009df17 May 2, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-utoipa-annotation-for-infra-id-voltages branch May 2, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants