Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add utoipa annotation for infra/{id}/unlock #7328

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 29, 2024

Part of #4580

@hamz2a hamz2a requested review from a team as code owners April 29, 2024 09:32
@hamz2a hamz2a changed the title editoast: add utoipa annotation for infra/{id}/unlock editoast: add utoipa annotation for infra/{id}/unlock Apr 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.09%. Comparing base (ee75b28) to head (7633fcc).

Files Patch % Lines
...s/InfraSelector/InfraSelectorEditionActionsBar.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7328      +/-   ##
============================================
- Coverage     29.09%   29.09%   -0.01%     
  Complexity     2020     2020              
============================================
  Files          1137     1137              
  Lines        139639   139647       +8     
  Branches       2757     2757              
============================================
+ Hits          40626    40627       +1     
- Misses        97404    97411       +7     
  Partials       1609     1609              
Flag Coverage Δ
core 76.76% <ø> (ø)
editoast 72.05% <100.00%> (-0.02%) ⬇️
front 9.34% <85.71%> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this utoipa work. I noticed id has been changed to infra_id. Is it intended to convert our API to a more explicit name?

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@hamz2a
Copy link
Contributor Author

hamz2a commented Apr 30, 2024

Thanks for following up on this utoipa work. I noticed id has been changed to infra_id. Is it intended to convert our API to a more explicit name?

Yes

@hamz2a hamz2a added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit be2941a Apr 30, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-utoipa-annotation-for-infra-id-unlock branch April 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants