Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move many items to editoast_schemas::primitives #7297

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 23, 2024

part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 23, 2024 09:45
@hamz2a hamz2a force-pushed the hai/editoast-move-many-items-to-editoast-schemas-primitives branch from 341a6bf to 8fee1ef Compare April 23, 2024 10:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 28.44%. Comparing base (453750c) to head (8fee1ef).
Report is 1 commits behind head on dev.

Files Patch % Lines
...st/editoast_schemas/src/primitives/bounding_box.rs 95.45% 4 Missing ⚠️
editoast/editoast_schemas/src/primitives/zone.rs 20.00% 4 Missing ⚠️
...ast/editoast_schemas/src/primitives/object_type.rs 90.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7297      +/-   ##
============================================
+ Coverage     28.30%   28.44%   +0.13%     
  Complexity     2022     2022              
============================================
  Files          1149     1153       +4     
  Lines        140065   139297     -768     
  Branches       2728     2728              
============================================
- Hits          39652    39621      -31     
+ Misses        98788    98051     -737     
  Partials       1625     1625              
Flag Coverage Δ
core 78.05% <ø> (ø)
editoast 72.04% <91.66%> (+1.90%) ⬆️
front 9.14% <ø> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a added this pull request to the merge queue Apr 23, 2024
Merged via the queue into dev with commit c52dcd0 Apr 23, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-many-items-to-editoast-schemas-primitives branch April 23, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants