Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add budget field in editoast search study response #7290

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Apr 22, 2024

Also adds the migration definition block that was missing for the study object.

@leovalais leovalais requested a review from a team as a code owner April 22, 2024 14:52
@leovalais leovalais requested a review from RomainValls April 22, 2024 14:53
@leovalais leovalais force-pushed the lva/search-study-budget branch from 37f25d4 to abb26ea Compare April 22, 2024 14:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.35%. Comparing base (da749b8) to head (1166ada).

Files Patch % Lines
editoast/src/client/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7290      +/-   ##
============================================
- Coverage     28.36%   28.35%   -0.01%     
  Complexity     2006     2006              
============================================
  Files          1139     1139              
  Lines        139897   139899       +2     
  Branches       2707     2707              
============================================
- Hits          39680    39671       -9     
- Misses        98599    98610      +11     
  Partials       1618     1618              
Flag Coverage Δ
core 78.21% <ø> (ø)
editoast 70.62% <0.00%> (-0.04%) ⬇️
front 9.14% <100.00%> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/search-study-budget branch from abb26ea to 1166ada Compare April 22, 2024 17:04
@leovalais leovalais requested a review from flomonster April 22, 2024 17:07
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais enabled auto-merge April 22, 2024 17:09
@leovalais leovalais added this pull request to the merge queue Apr 22, 2024
Merged via the queue into dev with commit 0bf04ff Apr 22, 2024
17 checks passed
@leovalais leovalais deleted the lva/search-study-budget branch April 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants