Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: core-client: add retry on broken pipes errors #7283

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Apr 19, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 28.66%. Comparing base (b86407f) to head (8480f19).

Files Patch % Lines
editoast/src/core/mod.rs 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7283      +/-   ##
============================================
+ Coverage     28.39%   28.66%   +0.26%     
  Complexity     2022     2022              
============================================
  Files          1148     1132      -16     
  Lines        139683   138253    -1430     
  Branches       2727     2727              
============================================
- Hits          39669    39626      -43     
+ Misses        98390    97003    -1387     
  Partials       1624     1624              
Flag Coverage Δ
core 78.05% <ø> (ø)
editoast 70.10% <0.00%> (-0.05%) ⬇️
front 9.19% <ø> (ø)
gateway ?
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Castavo Castavo force-pushed the bpt/editoast/broken-pipe branch 2 times, most recently from 0dd6a5d to c6e282d Compare April 23, 2024 09:37
@Castavo Castavo marked this pull request as ready for review April 23, 2024 09:52
@Castavo Castavo requested review from a team as code owners April 23, 2024 09:52
@Castavo Castavo requested review from Tguisnet and SharglutDev April 23, 2024 09:53
editoast/src/core/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Castavo Castavo force-pushed the bpt/editoast/broken-pipe branch from b1afaaf to 8480f19 Compare April 23, 2024 12:07
@Castavo Castavo enabled auto-merge April 23, 2024 12:08
@Castavo Castavo added this pull request to the merge queue Apr 23, 2024
Merged via the queue into dev with commit da134b9 Apr 23, 2024
17 checks passed
@Castavo Castavo deleted the bpt/editoast/broken-pipe branch April 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants