Split ModelV2 codegen in multiple submodules (part 2) #7269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7269 +/- ##
=============================================
+ Coverage 28.44% 87.49% +59.04%
=============================================
Files 1155 31 -1124
Lines 140091 1535 -138556
Branches 2845 0 -2845
=============================================
- Hits 39849 1343 -38506
+ Misses 98592 192 -98400
+ Partials 1650 0 -1650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leovalais
force-pushed
the
lva/organize-modelsv2-derive-part-3
branch
from
2c46869 to
b3e66c8
Compare
Renames: - Indentifier => RawIdentifier - TypedIdentifier => Identifier - Restore former identifier field names in ModelConfig
leovalais
force-pushed
the
lva/organize-modelsv2-derive-part-3
branch
from
71f496b to
193b7d3
Compare
woshilapin
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines for each generated code block (struct definition, impl block, trait implementation) a struct
implementing
ToTokensto isolate (almost) all quoting intomodelv2::codegen.A little refactoring of
Identifierswas necessary to make the-Implstruct API convenient.Tip
This PR can be reviewed commit by commit.