Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move BoundingBox and Zone to editoast_schemas #7258

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 18, 2024

Part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 18, 2024 09:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@b3228a3). Click here to learn what that means.

Files Patch % Lines
editoast/editoast_schemas/src/primitives.rs 91.39% 8 Missing ⚠️
editoast/editoast_schemas/src/errors.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #7258   +/-   ##
======================================
  Coverage       ?   28.45%           
  Complexity     ?     2299           
======================================
  Files          ?     1154           
  Lines          ?   140149           
  Branches       ?     2845           
======================================
  Hits           ?    39884           
  Misses         ?    98615           
  Partials       ?     1650           
Flag Coverage Δ
core 78.55% <ø> (?)
editoast 70.30% <89.47%> (?)
front 9.14% <ø> (?)
gateway 2.43% <ø> (?)
railjson_generator 87.49% <ø> (?)
tests 83.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais self-requested a review April 18, 2024 10:11
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but let's wait on @leovalais's review because I'm not sure to understand the inventory::submit part.

editoast/editoast_schemas/src/primitives.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-move-bounding-box-and-zone-to-editoast-schemas branch from 7fa27c4 to 85e6c8d Compare April 18, 2024 12:58
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few dependency issues.

@woshilapin We use inventory to register each error type that the frontend might receive and export them in our OpenApi. This way the frontend can have all their keys and translate them. Until now, all those inventory::submit! were generated by the EditoastError derive macro. So this is fine for now, but we'll need to find a solution later because we can't manually add that for each error we have.

editoast/Cargo.toml Outdated Show resolved Hide resolved
editoast/editoast_schemas/Cargo.toml Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-move-bounding-box-and-zone-to-editoast-schemas branch from 85e6c8d to f343e57 Compare April 18, 2024 16:16
@hamz2a hamz2a requested a review from leovalais April 18, 2024 16:19
@hamz2a hamz2a force-pushed the hai/editoast-move-bounding-box-and-zone-to-editoast-schemas branch 2 times, most recently from 6bd535e to 3964911 Compare April 19, 2024 08:21
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor changes

editoast/editoast_schemas/Cargo.toml Outdated Show resolved Hide resolved
editoast/editoast_schemas/src/primitives.rs Outdated Show resolved Hide resolved
editoast/src/error.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-move-bounding-box-and-zone-to-editoast-schemas branch from 3964911 to 03877be Compare April 19, 2024 10:11
@hamz2a hamz2a force-pushed the hai/editoast-move-bounding-box-and-zone-to-editoast-schemas branch from 03877be to 2305d89 Compare April 19, 2024 10:12
@hamz2a hamz2a requested a review from leovalais April 19, 2024 10:30
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@hamz2a hamz2a added this pull request to the merge queue Apr 19, 2024
Merged via the queue into dev with commit 53e5f14 Apr 19, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-bounding-box-and-zone-to-editoast-schemas branch April 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants