-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: move BoundingBox
and Zone
to editoast_schemas
#7258
editoast: move BoundingBox
and Zone
to editoast_schemas
#7258
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7258 +/- ##
======================================
Coverage ? 28.45%
Complexity ? 2299
======================================
Files ? 1154
Lines ? 140149
Branches ? 2845
======================================
Hits ? 39884
Misses ? 98615
Partials ? 1650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but let's wait on @leovalais's review because I'm not sure to understand the inventory::submit
part.
7fa27c4
to
85e6c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few dependency issues.
@woshilapin We use inventory
to register each error type that the frontend might receive and export them in our OpenApi. This way the frontend can have all their keys and translate them. Until now, all those inventory::submit!
were generated by the EditoastError
derive macro. So this is fine for now, but we'll need to find a solution later because we can't manually add that for each error we have.
85e6c8d
to
f343e57
Compare
6bd535e
to
3964911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor changes
3964911
to
03877be
Compare
03877be
to
2305d89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Part of #7048