Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move infra items to editoast_schemas part 2 #7246

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 17, 2024

Part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 17, 2024 13:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.53%. Comparing base (9b4c70e) to head (21d1a5d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7246       +/-   ##
=============================================
+ Coverage     28.19%   70.53%   +42.33%     
  Complexity     2289     2289               
=============================================
  Files          1135      570      -565     
  Lines        139473    41369    -98104     
  Branches       2801     1871      -930     
=============================================
- Hits          39328    29179    -10149     
+ Misses        98514    11484    -87030     
+ Partials       1631      706      -925     
Flag Coverage Δ
core 78.52% <ø> (ø)
editoast 70.08% <100.00%> (-0.03%) ⬇️
front ?
gateway 2.45% <ø> (ø)
railjson_generator ?
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for shipping!

@hamz2a hamz2a added this pull request to the merge queue Apr 17, 2024
Merged via the queue into dev with commit 40c175f Apr 17, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-infra-items-to-editoast-schemas-part-2 branch April 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants