Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move infra items to editoast_schemas #7228

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 16, 2024

Part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 16, 2024 12:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.18%. Comparing base (6684771) to head (2228080).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7228      +/-   ##
============================================
- Coverage     28.19%   28.18%   -0.01%     
  Complexity     2273     2273              
============================================
  Files          1128     1128              
  Lines        139439   139439              
  Branches       2804     2804              
============================================
- Hits          39310    39300      -10     
- Misses        98497    98507      +10     
  Partials       1632     1632              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 70.08% <100.00%> (-0.04%) ⬇️
front 9.10% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bulk, thanks.

@hamz2a hamz2a added this pull request to the merge queue Apr 16, 2024
Merged via the queue into dev with commit cff11f9 Apr 16, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-infra-items-to-editoast-schemas branch April 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants