Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editoast path properties schema #7226

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

flomonster
Copy link
Contributor

No description provided.

@flomonster flomonster marked this pull request as ready for review April 16, 2024 10:27
@flomonster flomonster requested a review from a team as a code owner April 16, 2024 10:27
@flomonster flomonster force-pushed the fam/fix-pathfinding-properties branch from 5e5cbc4 to a3e56a4 Compare April 16, 2024 10:28
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.19%. Comparing base (418a24b) to head (8c52d24).
Report is 17 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7226   +/-   ##
=========================================
  Coverage     28.19%   28.19%           
  Complexity     2273     2273           
=========================================
  Files          1124     1128    +4     
  Lines        139437   139460   +23     
  Branches       2804     2804           
=========================================
+ Hits          39312    39320    +8     
- Misses        98493    98508   +15     
  Partials       1632     1632           
Flag Coverage Δ
core 78.58% <ø> (-0.02%) ⬇️
editoast 70.09% <100.00%> (-0.04%) ⬇️
front 9.11% <100.00%> (+0.01%) ⬆️
gateway 2.45% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

editoast/openapi.yaml Outdated Show resolved Hide resolved
@flomonster flomonster force-pushed the fam/fix-pathfinding-properties branch 3 times, most recently from c4c45bc to 4cb2c48 Compare April 16, 2024 16:29
@flomonster flomonster force-pushed the fam/fix-pathfinding-properties branch from 4cb2c48 to 8c52d24 Compare April 17, 2024 06:52
@flomonster flomonster added this pull request to the merge queue Apr 17, 2024
Merged via the queue into dev with commit f7d6bdb Apr 17, 2024
17 checks passed
@flomonster flomonster deleted the fam/fix-pathfinding-properties branch April 17, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants