-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: move train schedule base to schemas #7177
Conversation
92c1aed
to
92f08b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that the end of editoast/src/schema/v2/mod.rs
🎉 Thanks for the PR.
For the renaming of TrainScheduleBase
into TrainSchedule
, I agree with you, but let's wait for @leovalais to give an approval on that (he knows better than me).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ping @flomonster for the renaming of TrainScheduleBase
in TrainSchedule
since he's the most involved with TrainScheduleV2. I'd be in favor of renaming unless there's a specific reason it was named this way.
3028549
to
a272021
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7177 +/- ##
======================================
Coverage ? 28.46%
Complexity ? 2299
======================================
Files ? 1154
Lines ? 140044
Branches ? 2845
======================================
Hits ? 39867
Misses ? 98527
Partials ? 1650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d5ba2e3
to
9f38dd2
Compare
9f38dd2
to
5d4ec2e
Compare
Hey @leovalais and @flomonster, let's merge this PR. It's blocking @hamz2a. We can make any potential modifications in another PR. |
part of #7048