Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move train schedule base to schemas #7177

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 11, 2024

part of #7048

  • Maybe rename TrainScheduleBase to TrainSchedule ?
  • Move train schedule base to schemas
  • Move tests to schemas
  • Copy a json file exemple of train schedule for testing

@Wadjetz Wadjetz added area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic labels Apr 11, 2024
@Wadjetz Wadjetz self-assigned this Apr 11, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedule-base-to-schemas branch 2 times, most recently from 92c1aed to 92f08b4 Compare April 12, 2024 07:45
@Wadjetz Wadjetz requested a review from woshilapin April 12, 2024 07:46
@Wadjetz Wadjetz marked this pull request as ready for review April 12, 2024 07:50
@Wadjetz Wadjetz requested a review from a team as a code owner April 12, 2024 07:50
@Wadjetz Wadjetz requested a review from leovalais April 12, 2024 07:50
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that the end of editoast/src/schema/v2/mod.rs 🎉 Thanks for the PR.

For the renaming of TrainScheduleBase into TrainSchedule, I agree with you, but let's wait for @leovalais to give an approval on that (he knows better than me).

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ping @flomonster for the renaming of TrainScheduleBase in TrainSchedule since he's the most involved with TrainScheduleV2. I'd be in favor of renaming unless there's a specific reason it was named this way.

@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedule-base-to-schemas branch 2 times, most recently from 3028549 to a272021 Compare April 16, 2024 07:43
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@b3228a3). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #7177   +/-   ##
======================================
  Coverage       ?   28.46%           
  Complexity     ?     2299           
======================================
  Files          ?     1154           
  Lines          ?   140044           
  Branches       ?     2845           
======================================
  Hits           ?    39867           
  Misses         ?    98527           
  Partials       ?     1650           
Flag Coverage Δ
core 78.55% <ø> (?)
editoast 70.51% <100.00%> (?)
front 9.14% <ø> (?)
gateway 2.43% <ø> (?)
railjson_generator 87.49% <ø> (?)
tests 83.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedule-base-to-schemas branch 5 times, most recently from d5ba2e3 to 9f38dd2 Compare April 17, 2024 08:49
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedule-base-to-schemas branch from 9f38dd2 to 5d4ec2e Compare April 19, 2024 10:50
@Wadjetz
Copy link
Member Author

Wadjetz commented Apr 19, 2024

Hey @leovalais and @flomonster, let's merge this PR. It's blocking @hamz2a. We can make any potential modifications in another PR.

@Wadjetz Wadjetz added this pull request to the merge queue Apr 19, 2024
Merged via the queue into dev with commit 659afff Apr 19, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-move-train-schedule-base-to-schemas branch April 19, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants