Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: move track offset, margins path item to schemas #7168

Merged
merged 6 commits into from
Apr 11, 2024
Merged

editoast: move track offset, margins path item to schemas #7168

merged 6 commits into from
Apr 11, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 10, 2024 •
edited
Loading

part of #7048

  • Move track offset to schemas
  • Move train schedule margins to schemas
  • Move train schedule path item to schemas
  • Move train schedule schedule_item to schemas
  • Update openapi
  • move margins tests

@Wadjetz Wadjetz added area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic labels Apr 10, 2024
@Wadjetz Wadjetz self-assigned this Apr 10, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedules-structs-to-schemas branch 3 times, most recently from ab03b92 to 90cba6c Compare April 10, 2024 13:23
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedules-structs-to-schemas branch from 90cba6c to 2e74199 Compare April 10, 2024 13:29
@Wadjetz Wadjetz changed the title editoast: move track offset to schemas editoast: move track offset, margins to schemas Apr 10, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-train-schedules-structs-to-schemas branch from 2e74199 to 3a03f98 Compare April 10, 2024 13:36
@Wadjetz Wadjetz changed the title editoast: move track offset, margins to schemas editoast: move track offset, margins path item to schemas Apr 10, 2024
@Wadjetz Wadjetz marked this pull request as ready for review April 10, 2024 14:09
@Wadjetz Wadjetz requested a review from a team as a code owner April 10, 2024 14:09
woshilapin
woshilapin approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few more to go 😜.

@Wadjetz Wadjetz added this pull request to the merge queue Apr 11, 2024
Merged via the queue into dev with commit a4c4431 Apr 11, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-move-train-schedules-structs-to-schemas branch April 11, 2024 07:40
@woshilapin woshilapin mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@younesschrifi younesschrifi Awaiting requested review from younesschrifi

Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wadjetz @woshilapin