-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: move rolling stock and rs with liveries to schemas to schemas #7128
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7128 +/- ##
============================================
- Coverage 28.34% 28.34% -0.01%
Complexity 2247 2247
============================================
Files 1097 1096 -1
Lines 137950 137931 -19
Branches 2761 2754 -7
============================================
- Hits 39103 39094 -9
+ Misses 97247 97239 -8
+ Partials 1600 1598 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f67787d
to
e213b98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. There are a few things to change, including some changes that went while I was off:
- As stated in the tracking issue Isolate
editoast::schema
into aneditoast_schemas
crate #7048 (comment), there should be only one definition of RollingStock in editoast_schemas. - RollingStockWithLiveries is a view response, not a schema. It should be moved into views/.
- Please reference the tracking issues in the description of the PR, that helps the review ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
038f823
to
31ef244
Compare
31ef244
to
31c0071
Compare
c88bd70
to
da19bc7
Compare
167629d
to
b62feaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
b62feaf
to
7466606
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
part of #7048