Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: create stdcm simulation sheet #7080

Merged
merged 1 commit into from
May 15, 2024
Merged

front: create stdcm simulation sheet #7080

merged 1 commit into from
May 15, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Apr 3, 2024 •
edited
Loading

Create a simulation report sheet in STDCM.

closes #6992
closes #6998
closes #7009

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (a1681e8) to head (29b614b).
Report is 5 commits behind head on dev.

Additional details and impacted files 
@@              Coverage Diff              @@
##                dev    #7080       +/-   ##
=============================================
+ Coverage     28.34%   87.15%   +58.80%     
=============================================
  Files          1095       29     -1066     
  Lines        137950     1502   -136448     
  Branches       2761        0     -2761     
=============================================
- Hits          39102     1309    -37793     
+ Misses        97248      193    -97055     
+ Partials       1600        0     -1600
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.15% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch 9 times, most recently from ff76b54 to 9ea8dc3 Compare April 11, 2024 15:38
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch from 85d42be to f78b5bf Compare April 17, 2024 08:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.55970% with 1066 lines in your changes are missing coverage. Please review.

Project coverage is 29.22%. Comparing base (e0ac6bb) to head (79dc723).

Files Patch % Lines
...ons/stdcm/components/SimulationReportStyleSheet.ts 0.00% 567 Missing and 1 partial ⚠️
...cations/stdcm/components/SimulationReportSheet.tsx 0.00% 358 Missing and 1 partial ⚠️
front/src/applications/stdcm/utils.ts 0.00% 34 Missing and 1 partial ⚠️
.../src/applications/stdcm/views/OSRDStdcmResults.tsx 0.00% 35 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 27 Missing ⚠️
...t/src/applications/stdcm/views/OSRDStdcmConfig.tsx 0.00% 14 Missing ⚠️
front/src/utils/date.ts 16.66% 10 Missing ⚠️
front/src/utils/timeManipulation.ts 28.57% 10 Missing ⚠️
front/src/applications/stdcm/views/OSRDSTDCM.tsx 0.00% 4 Missing ⚠️
...src/applications/stdcm/views/StdcmRequestModal.tsx 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7080      +/-   ##
============================================
- Coverage     29.44%   29.22%   -0.23%     
  Complexity     2012     2012              
============================================
  Files          1162     1165       +3     
  Lines        143499   144559    +1060     
  Branches       2808     2811       +3     
============================================
- Hits          42254    42248       -6     
- Misses        99587   100650    +1063     
- Partials       1658     1661       +3
Flag Coverage Δ
core 76.24% <ø> (ø)
editoast 72.29% <ø> (-0.05%) ⬇️
front 9.73% <0.55%> (-0.10%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch 7 times, most recently from c4d522c to 4a56f30 Compare April 24, 2024 10:19
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch from 5cde537 to aadf2da Compare April 25, 2024 06:43
@Akctarus Akctarus marked this pull request as ready for review April 25, 2024 07:32
@Akctarus Akctarus requested a review from a team as a code owner April 25, 2024 07:32
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch 8 times, most recently from 646a4e8 to c43cd24 Compare April 25, 2024 11:55
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch from c43cd24 to c34237c Compare April 25, 2024 15:15
clarani
clarani requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR !! Left some comments :)

front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportStyleSheet.ts Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/public/locales/en/stdcm-simulation-sheet.json Outdated Show resolved Hide resolved
front/public/locales/fr/stdcm-simulation-sheet.json Outdated Show resolved Hide resolved
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch 3 times, most recently from d4a2138 to fa4224e Compare April 30, 2024 14:46
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch from 1bdbe35 to 0f30da9 Compare April 30, 2024 16:17
clarani
clarani reviewed May 7, 2024
View reviewed changes
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportStyleSheet.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/views/OSRDStdcmResults.tsx Outdated Show resolved Hide resolved
front/src/utils/date.ts Outdated Show resolved Hide resolved
front/src/utils/date.ts Outdated Show resolved Hide resolved
front/src/utils/timeManipulation.ts Outdated Show resolved Hide resolved
front/src/utils/timeManipulation.ts Outdated Show resolved Hide resolved
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch 2 times, most recently from 13296ab to 32566e3 Compare May 10, 2024 12:37
clarani
clarani reviewed May 13, 2024
View reviewed changes
front/src/applications/stdcm/utils.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/utils.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx Outdated Show resolved Hide resolved
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch 4 times, most recently from 94d60a9 to 300c917 Compare May 15, 2024 08:55
clarani
clarani approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ tested
I just left some comments, you can fix them in your next PR

front/src/modules/trainschedule/components/ManageTrainSchedule/Map.tsx Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/Map.tsx Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/Map.tsx Show resolved Hide resolved
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch from 300c917 to 1b28e16 Compare May 15, 2024 09:32
@Akctarus Akctarus force-pushed the tmn/stdcm-simulation-sheet branch from 1b28e16 to 79dc723 Compare May 15, 2024 09:35
@Akctarus Akctarus mentioned this pull request May 15, 2024
Closed
@Akctarus Akctarus added this pull request to the merge queue May 15, 2024
Merged via the queue into dev with commit e74ccaa May 15, 2024
17 checks passed
@Akctarus Akctarus deleted the tmn/stdcm-simulation-sheet branch May 15, 2024 10:05
@Akctarus Akctarus mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Akctarus @codecov-commenter @clarani