Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move RollingStockSeparatedImageModel to modelv2 #6787

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Mar 4, 2024

closes #6778

@hamz2a hamz2a requested a review from a team as a code owner March 4, 2024 13:22
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 28.27%. Comparing base (4f7b93f) to head (ddfefc6).
Report is 1 commits behind head on dev.

Files Patch % Lines
editoast/src/views/rolling_stocks/mod.rs 0.00% 6 Missing ⚠️
editoast/src/modelsv2/rolling_stock_image.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6787   +/-   ##
=========================================
  Coverage     28.27%   28.27%           
  Complexity     2177     2177           
=========================================
  Files          1048     1048           
  Lines        129976   129979    +3     
  Branches       2577     2577           
=========================================
+ Hits          36754    36758    +4     
+ Misses        91733    91732    -1     
  Partials       1489     1489           
Flag Coverage Δ
core 79.39% <ø> (ø)
editoast 75.89% <0.00%> (+<0.01%) ⬆️
front 8.62% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested

editoast/src/modelsv2/rolling_stock_image.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-move-rolling-stock-separated-image-to-model-v2 branch from 8749498 to ddfefc6 Compare March 4, 2024 13:58
@hamz2a hamz2a added this pull request to the merge queue Mar 4, 2024
Merged via the queue into dev with commit 4c8a4c1 Mar 4, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-rolling-stock-separated-image-to-model-v2 branch March 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move RollingStockSeparatedImageModel to modelv2
2 participants