-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: pathfinding: allow completion by station name in search by trigram #6768
front: pathfinding: allow completion by station name in search by trigram #6768
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6768 +/- ##
============================================
- Coverage 28.34% 28.31% -0.04%
Complexity 2250 2250
============================================
Files 1087 1090 +3
Lines 136329 136477 +148
Branches 2744 2745 +1
============================================
- Hits 38648 38637 -11
- Misses 96085 96243 +158
- Partials 1596 1597 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ca59387
to
a209acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thx for the code!
Here some minor bugs I've found ;) Good luck!
The column expands when too much suggestions, it should stay with same width. record1.mp4 |
Suggestions should be removed when text is removed. record2.mp4 |
Suggestions should appear only with whole word (so nothing here) record3.mp4 |
Suggestions should be removed when removing text OR take the whole word in consideration record4.mp4 |
Same as above: you can fix this by taking care about the whole word and not only what is entered. record5.mp4 |
|
817fac5
to
7bcd3f5
Compare
7bcd3f5
to
a3722a7
Compare
Hi! Thx for corrections. A few bugs persist, see below ;-) |
bug1.mp4 |
bug2.mp4 |
This one is a little bit tricky but frequently comes when you "hesitate" during typing. bug3.mp4 |
ed5c9af
to
bb37242
Compare
The last one! Don't despair... ;-)
I think the good behaviour would either propose suggestions for next text ("RE" in my example) either propose nothing. pouet.mp4 |
bb37242
to
b613733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionnaly tested & ok! Good job, GG!
b613733
to
85ce38c
Compare
…gram - add operationalPointsSearch API call in TypeAndPath.tsx - add possibility to search a trigram by station name in the rocket input - display results in the list below the component - edit _typeAndPath.scss - allow the search of a trigram between two trigrams - add a pseudo ellipsis to show there is too much results - the arrow follow the current word in the center of it - create typeAndPath.json in locales/common for fr and en translation - move isCursorSurroundedBySpace, findCurrentWord and calculateAdjustedCursorPositionRem functions in utils/inputManipulation.ts
85ce38c
to
1cb8b20
Compare
- during rebase in pr #6768 some fixup commits were dropped by mistake, they were retrieve with reflog
close #6626