Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - avoid API calls when no infra is selected #6734

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Feb 23, 2024

fix #6733

@sim51 sim51 requested a review from a team as a code owner February 23, 2024 15:15
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 27.93%. Comparing base (7da176a) to head (5aa11cc).
Report is 2 commits behind head on dev.

Files Patch % Lines
...src/applications/editor/components/LayersModal.tsx 0.00% 5 Missing ⚠️
front/src/applications/editor/Map.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6734   +/-   ##
=========================================
  Coverage     27.92%   27.93%           
  Complexity     2172     2172           
=========================================
  Files          1041     1041           
  Lines        128654   128655    +1     
  Branches       2567     2567           
=========================================
+ Hits          35926    35934    +8     
+ Misses        91245    91238    -7     
  Partials       1483     1483           
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.38% <ø> (-0.01%) ⬇️
front 8.41% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Feb 23, 2024
Merged via the queue into dev with commit 51f3ce3 Feb 23, 2024
22 checks passed
@nicolaswurtz nicolaswurtz deleted the bsi/issue-6733 branch February 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: editor - avoid 404 api calls when no infra is selected
2 participants