-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: fix putMany for redundant DistanceRangeMaps #6731
Conversation
686e337
to
8ab2218
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6731 +/- ##
=========================================
Coverage 27.93% 27.93%
- Complexity 2172 2177 +5
=========================================
Files 1041 1041
Lines 128655 128671 +16
Branches 2567 2571 +4
=========================================
+ Hits 35935 35948 +13
- Misses 91237 91240 +3
Partials 1483 1483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8ab2218
to
5f45ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the comments help understand at least the (edgy) case 👍
And the perf check is still OK.
core/kt-osrd-utils/src/main/kotlin/fr/sncf/osrd/utils/DistanceRangeMapImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-utils/src/main/kotlin/fr/sncf/osrd/utils/DistanceRangeMapImpl.kt
Outdated
Show resolved
Hide resolved
5f45ce0
to
a3a3c72
Compare
core/kt-osrd-utils/src/main/kotlin/fr/sncf/osrd/utils/DistanceRangeMapImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-utils/src/main/kotlin/fr/sncf/osrd/utils/DistanceRangeMapImpl.kt
Outdated
Show resolved
Hide resolved
7723b14
to
73d858e
Compare
fix #6726