Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix putMany for redundant DistanceRangeMaps #6731

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

shenriotpro
Copy link
Contributor

@shenriotpro shenriotpro commented Feb 23, 2024

fix #6726

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.93%. Comparing base (51f3ce3) to head (73d858e).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6731   +/-   ##
=========================================
  Coverage     27.93%   27.93%           
- Complexity     2172     2177    +5     
=========================================
  Files          1041     1041           
  Lines        128655   128671   +16     
  Branches       2567     2571    +4     
=========================================
+ Hits          35935    35948   +13     
- Misses        91237    91240    +3     
  Partials       1483     1483           
Flag Coverage Δ
core 79.39% <100.00%> (+0.02%) ⬆️
editoast 75.37% <ø> (-0.02%) ⬇️
front 8.41% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenriotpro shenriotpro changed the title WIP core: fix putMany for redundant DistanceRangeMaps core: fix putMany for redundant DistanceRangeMaps Feb 23, 2024
@shenriotpro shenriotpro marked this pull request as ready for review February 23, 2024 14:01
@shenriotpro shenriotpro requested a review from a team as a code owner February 23, 2024 14:01
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comments help understand at least the (edgy) case 👍
And the perf check is still OK.

@shenriotpro shenriotpro added this pull request to the merge queue Feb 26, 2024
Merged via the queue into dev with commit 21fafcc Feb 26, 2024
22 checks passed
@shenriotpro shenriotpro deleted the shenriot-fix-putmany branch February 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core: DistanceRangeMap.putMany() doesn't merge equal values for consecutive intervals
3 participants