front: editor - better handle api error on forms #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #6729 - When saving an object, throw the error data without casting it to error - remove unsued code in utils/error (was commented) - remove margin-botton on <p> on form's error so message is centered
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6730 +/- ##
============================================
- Coverage 27.92% 27.92% -0.01%
Complexity 2172 2172
============================================
Files 1041 1041
Lines 128661 128655 -6
Branches 2567 2567
============================================
- Hits 35928 35921 -7
- Misses 91250 91251 +1
Partials 1483 1483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sim51
force-pushed
the
bsi/issue-6729
branch
from
5730178 to
b4292f4
Compare
SharglutDev
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6729
on form's error so message is centered