front: tests: refacto allowances e2e-tests #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6697 +/- ##
============================================
+ Coverage 27.87% 27.90% +0.02%
Complexity 2172 2172
============================================
Files 1043 1041 -2
Lines 128726 128667 -59
Branches 2569 2567 -2
============================================
+ Hits 35887 35906 +19
+ Misses 91354 91278 -76
+ Partials 1485 1483 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
requested changes
Feb 21, 2024
Uriel-Sautron
approved these changes
Feb 22, 2024
SharglutDev
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Thank you for the fixes, allowancesManagement is nice.
One last thing that is available right now : when adding an engineering allowance like you do (without changing the interval range which takes the whole path by default), we can check that the input to add a new one is properly disabled
Yohh
force-pushed
the
yoh/front-tests-refacto-tests-end-to-end-allowances
branch
from
921cc8f to
373c201
Compare
SharglutDev
approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
- add data-testid where needed - clean createCompleteScenario in /assets/utils.ts to fit with global setup - edit some testId in scenario-page-model.ts
Yohh
force-pushed
the
yoh/front-tests-refacto-tests-end-to-end-allowances
branch
from
b49a870 to
85abd6b
Compare
SharglutDev
deleted the
yoh/front-tests-refacto-tests-end-to-end-allowances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5509