Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: config open telemetry propagator #6648

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Feb 15, 2024

Enable in geteway trace propagation to editoast

@Wadjetz Wadjetz self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5e1c2a3) 27.87% compared to head (e9399c4) 27.87%.
Report is 1 commits behind head on dev.

Files Patch % Lines
gateway/src/config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6648   +/-   ##
=========================================
  Coverage     27.87%   27.87%           
  Complexity     2171     2171           
=========================================
  Files          1044     1044           
  Lines        127892   127905   +13     
  Branches       2601     2601           
=========================================
+ Hits          35651    35655    +4     
- Misses        90723    90732    +9     
  Partials       1518     1518           
Flag Coverage Δ
core 79.35% <ø> (ø)
editoast 75.22% <ø> (+0.01%) ⬆️
front 8.42% <ø> (-0.01%) ⬇️
gateway 2.50% <0.00%> (-0.01%) ⬇️
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot test it right away, but the code seems fine. those modifications are enough to enable the tracing between services ?

@Wadjetz Wadjetz marked this pull request as ready for review February 15, 2024 10:20
@Wadjetz Wadjetz requested a review from a team as a code owner February 15, 2024 10:20
@Wadjetz Wadjetz force-pushed the ebe/gateway-open-telemetry-propagator branch from cb31c3a to e9399c4 Compare February 15, 2024 10:23
@Wadjetz
Copy link
Member Author

Wadjetz commented Feb 15, 2024

Cannot test it right away, but the code seems fine. those modifications are enough to enable the tracing between services ?

I think yes, it will send the traceparent header to editoast

@Wadjetz Wadjetz added this pull request to the merge queue Feb 15, 2024
Merged via the queue into dev with commit 0b7e794 Feb 15, 2024
22 checks passed
@Wadjetz Wadjetz deleted the ebe/gateway-open-telemetry-propagator branch February 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants