Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add stdcm test e2e #6644

Merged
merged 2 commits into from
Feb 16, 2024
Merged

front: add stdcm test e2e #6644

merged 2 commits into from
Feb 16, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 14, 2024

closes #5342

@clarani clarani requested a review from a team as a code owner February 14, 2024 16:40
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b597500) 27.79% compared to head (54508ff) 27.79%.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6644      +/-   ##
============================================
- Coverage     27.79%   27.79%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1041     1041              
  Lines        128088   128088              
  Branches       2569     2569              
============================================
- Hits          35606    35601       -5     
- Misses        90997    91002       +5     
  Partials       1485     1485
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.19% <ø> (-0.03%) ⬇️
front 8.35% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni-5342-stdcm-test-e2e branch from 5c07d53 to 474c766 Compare February 14, 2024 17:09
Uriel-Sautron
Uriel-Sautron approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ! Thanks for your work !!

front/tests/pages/rolling-stock-selector-page.ts Show resolved Hide resolved
Yohh
Yohh approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Math-R
Math-R approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice basepage :)

@clarani clarani force-pushed the cni-5342-stdcm-test-e2e branch from 474c766 to 54508ff Compare February 16, 2024 12:28
@clarani clarani enabled auto-merge February 16, 2024 12:29
@clarani clarani added this pull request to the merge queue Feb 16, 2024
Merged via the queue into dev with commit 41f5bcc Feb 16, 2024
22 checks passed
@clarani clarani deleted the cni-5342-stdcm-test-e2e branch February 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

@Math-R Math-R Math-R approved these changes

@Yohh Yohh Yohh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: refacto E2E tests: stdcm page
4 participants
@clarani @Yohh @Math-R @Uriel-Sautron