Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core schedule metadata extraction #6629

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Feb 13, 2024

Stop duration was ignored computing stops timings.

close #6609

@flomonster flomonster requested a review from a team as a code owner February 13, 2024 13:49
@flomonster flomonster requested a review from eckter February 13, 2024 13:49
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4105b19) 27.88% compared to head (7f5bc89) 27.87%.
Report is 2 commits behind head on dev.

Files Patch % Lines
.../sncf/osrd/standalone_sim/EnvelopeStopWrapper.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6629      +/-   ##
============================================
- Coverage     27.88%   27.87%   -0.02%     
+ Complexity     2175     2171       -4     
============================================
  Files          1044     1044              
  Lines        127897   127897              
  Branches       2605     2601       -4     
============================================
- Hits          35666    35651      -15     
- Misses        90712    90728      +16     
+ Partials       1519     1518       -1     
Flag Coverage Δ
core 79.35% <50.00%> (-0.02%) ⬇️
editoast 75.20% <ø> (-0.02%) ⬇️
front 8.42% <ø> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/fix-simulation-output-stops branch from dac7244 to b495430 Compare February 13, 2024 14:14
@flomonster flomonster force-pushed the fam/fix-simulation-output-stops branch from b495430 to 229c988 Compare February 13, 2024 14:49
Stop duration was ignored computing stops timings
@eckter eckter force-pushed the fam/fix-simulation-output-stops branch from 81b2da3 to 841f029 Compare February 13, 2024 14:58
@flomonster flomonster force-pushed the fam/fix-simulation-output-stops branch from 841f029 to 7f5bc89 Compare February 13, 2024 15:00
@flomonster flomonster enabled auto-merge February 13, 2024 15:02
@flomonster flomonster added this pull request to the merge queue Feb 13, 2024
Merged via the queue into dev with commit f00b337 Feb 13, 2024
22 checks passed
@flomonster flomonster deleted the fam/fix-simulation-output-stops branch February 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver train schedule is not correctly updated after adding a stop
2 participants