Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix the error condition for Datadog report #6628

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

woshilapin
Copy link
Contributor

Ooops, should be false below 400, not true.

@woshilapin woshilapin requested a review from bloussou February 13, 2024 13:49
@woshilapin woshilapin requested a review from a team as a code owner February 13, 2024 13:49
@woshilapin woshilapin requested a review from multun February 13, 2024 13:49
@woshilapin woshilapin force-pushed the wsl/feat/core-otel-datadog branch from fac7dea to 6f8adec Compare February 13, 2024 13:51
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4105b19) 27.88% compared to head (6f8adec) 27.88%.

Files Patch % Lines
core/src/main/java/fr/sncf/osrd/cli/TkDataDog.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6628   +/-   ##
=========================================
  Coverage     27.88%   27.88%           
  Complexity     2175     2175           
=========================================
  Files          1044     1044           
  Lines        127897   127897           
  Branches       2605     2605           
=========================================
+ Hits          35666    35668    +2     
+ Misses        90712    90710    -2     
  Partials       1519     1519           
Flag Coverage Δ
core 79.36% <0.00%> (ø)
editoast 75.23% <ø> (+<0.01%) ⬆️
front 8.42% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin added this pull request to the merge queue Feb 13, 2024
Merged via the queue into dev with commit de5edb4 Feb 13, 2024
22 checks passed
@woshilapin woshilapin deleted the wsl/feat/core-otel-datadog branch February 13, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants