-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bpt/editoast/parallel core requests #6624
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6624 +/- ##
============================================
+ Coverage 27.86% 27.88% +0.01%
+ Complexity 2178 2175 -3
============================================
Files 1042 1044 +2
Lines 127852 127897 +45
Branches 2610 2605 -5
============================================
+ Hits 35627 35664 +37
- Misses 90694 90714 +20
+ Partials 1531 1519 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f654d1
to
b66831a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you show an execution time comparison on the benchmark to check that we are not introducing bugs (loosing some trains) and having better performances ? |
b66831a
to
8bac61a
Compare
@bloussou I've run the benchmark, no errors are added, and the two all-stops payloads now run in about 2min each 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect !!
closes #6581