Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bpt/editoast/parallel core requests #6624

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Feb 13, 2024

closes #6581

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (eee07b8) 27.86% compared to head (8bac61a) 27.88%.
Report is 5 commits behind head on dev.

Files Patch % Lines
editoast/src/views/timetable/import.rs 0.00% 22 Missing ⚠️
editoast/src/core/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6624      +/-   ##
============================================
+ Coverage     27.86%   27.88%   +0.01%     
+ Complexity     2178     2175       -3     
============================================
  Files          1042     1044       +2     
  Lines        127852   127897      +45     
  Branches       2610     2605       -5     
============================================
+ Hits          35627    35664      +37     
- Misses        90694    90714      +20     
+ Partials       1531     1519      -12     
Flag Coverage Δ
core 79.36% <ø> (-0.02%) ⬇️
editoast 75.21% <0.00%> (-0.05%) ⬇️
front 8.42% <ø> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Castavo Castavo marked this pull request as ready for review February 13, 2024 11:20
@Castavo Castavo requested a review from a team as a code owner February 13, 2024 11:20
@Castavo Castavo requested review from leovalais, bloussou and flomonster and removed request for leovalais February 13, 2024 11:20
@Castavo Castavo force-pushed the bpt/editoast/parallel-core-requests branch from 9f654d1 to b66831a Compare February 13, 2024 11:28
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bloussou
Copy link
Contributor

Can you show an execution time comparison on the benchmark to check that we are not introducing bugs (loosing some trains) and having better performances ?

@Castavo Castavo force-pushed the bpt/editoast/parallel-core-requests branch from b66831a to 8bac61a Compare February 13, 2024 11:51
@Castavo
Copy link
Contributor Author

Castavo commented Feb 13, 2024

@bloussou I've run the benchmark, no errors are added, and the two all-stops payloads now run in about 2min each 😁

Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !!

@Castavo Castavo added this pull request to the merge queue Feb 13, 2024
Merged via the queue into dev with commit 4105b19 Feb 13, 2024
22 checks passed
@Castavo Castavo deleted the bpt/editoast/parallel-core-requests branch February 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: Make POST /timetable/{id} use all core workers
3 participants