Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove isInEditor property of mapbuttons in reference map #6539

Merged

Conversation

nicolaswurtz
Copy link
Contributor

No description provided.

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner February 1, 2024 13:35
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc7f4b4) 87.44% compared to head (736099c) 28.03%.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #6539       +/-   ##
=============================================
- Coverage     87.44%   28.03%   -59.41%     
- Complexity        0     2167     +2167     
=============================================
  Files            29     1015      +986     
  Lines          1481   127548   +126067     
  Branches          0     2584     +2584     
=============================================
+ Hits           1295    35756    +34461     
- Misses          186    90298    +90112     
- Partials          0     1494     +1494     
Flag Coverage Δ
core 78.56% <ø> (?)
editoast 75.44% <ø> (?)
front 8.62% <ø> (?)
gateway 2.50% <ø> (?)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster merged commit e220992 into dev Feb 1, 2024
21 checks passed
@flomonster flomonster deleted the nwz/fix-reference-map-remove-isInEditor-mapbutton-property branch February 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants