Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use new osrd ui-icons project #6527

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Jan 31, 2024

close #6534

@nicolaswurtz nicolaswurtz force-pushed the nwz/use-osrd-ui-icons branch from 599cc56 to e3e37d3 Compare January 31, 2024 17:54
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 207 lines in your changes are missing coverage. Please review.

Comparison is base (e274e07) 27.79% compared to head (c3ec617) 27.79%.

Files Patch % Lines
...ions/operationalStudies/components/BreadCrumbs.tsx 0.00% 10 Missing ⚠️
...ont/src/common/Map/Buttons/ButtonResetViewport.tsx 0.00% 7 Missing ⚠️
front/src/common/Map/Settings/MapSettings.tsx 0.00% 7 Missing ⚠️
...s/InfraSelector/InfraSelectorEditionActionsBar.tsx 0.00% 6 Missing ⚠️
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 6 Missing ⚠️
...or/components/InfraErrors/InfraErrorMapControl.tsx 0.00% 5 Missing ⚠️
...rc/applications/editor/tools/trackEdition/tool.tsx 0.00% 5 Missing ⚠️
...applications/operationalStudies/views/Scenario.tsx 0.00% 5 Missing ⚠️
front/src/common/BootstrapSNCF/NavBarSNCF.tsx 0.00% 5 Missing ⚠️
front/src/common/Pathfinding/Pathfinding.tsx 16.66% 5 Missing ⚠️
... and 54 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6527      +/-   ##
============================================
- Coverage     27.79%   27.79%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1041     1041              
  Lines        128080   128088       +8     
  Branches       2569     2569              
============================================
+ Hits          35605    35606       +1     
- Misses        90990    90997       +7     
  Partials       1485     1485              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.22% <ø> (-0.01%) ⬇️
front 8.35% <2.35%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz force-pushed the nwz/use-osrd-ui-icons branch 5 times, most recently from 3b177fc to e884c0a Compare February 6, 2024 15:22
@nicolaswurtz nicolaswurtz marked this pull request as ready for review February 6, 2024 15:23
@nicolaswurtz nicolaswurtz requested a review from a team as a code owner February 6, 2024 15:23
@nicolaswurtz nicolaswurtz force-pushed the nwz/use-osrd-ui-icons branch from e884c0a to cc6ad95 Compare February 7, 2024 07:52
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Math-R Math-R enabled auto-merge February 7, 2024 11:11
@nicolaswurtz nicolaswurtz force-pushed the nwz/use-osrd-ui-icons branch 9 times, most recently from 1edc0ef to 9d79dab Compare February 15, 2024 18:21
@Math-R Math-R added this pull request to the merge queue Feb 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2024
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Feb 15, 2024
Merged via the queue into dev with commit b597500 Feb 15, 2024
22 checks passed
@nicolaswurtz nicolaswurtz deleted the nwz/use-osrd-ui-icons branch February 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use UI-ICONS in whole project
3 participants