Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix layers button in editor #6526

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

RomainValls
Copy link
Contributor

closes #6518

@RomainValls RomainValls requested a review from a team as a code owner January 31, 2024 17:13
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ffd1ed) 28.04% compared to head (94d4ff8) 87.44%.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #6526       +/-   ##
=============================================
+ Coverage     28.04%   87.44%   +59.40%     
=============================================
  Files          1015       29      -986     
  Lines        127503     1481   -126022     
  Branches       2584        0     -2584     
=============================================
- Hits          35752     1295    -34457     
+ Misses        90257      186    -90071     
+ Partials       1494        0     -1494     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.44% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

front/src/common/Map/Buttons/MapButtons.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Buttons/MapButtons.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Buttons/ButtonMapSettingsEditor.tsx Outdated Show resolved Hide resolved
front/src/applications/editor/Editor.tsx Outdated Show resolved Hide resolved
@RomainValls RomainValls force-pushed the rvs/front-fix-layers-activation-in-editor branch from 1ff4997 to 434d056 Compare February 1, 2024 11:43
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with Romain ✅

@clarani clarani enabled auto-merge February 1, 2024 11:44
@RomainValls RomainValls force-pushed the rvs/front-fix-layers-activation-in-editor branch from 434d056 to d970a04 Compare February 1, 2024 11:46
@SharglutDev SharglutDev force-pushed the rvs/front-fix-layers-activation-in-editor branch from d970a04 to 94d4ff8 Compare February 1, 2024 11:57
@flomonster flomonster disabled auto-merge February 1, 2024 12:02
@flomonster flomonster merged commit fc7f4b4 into dev Feb 1, 2024
20 of 21 checks passed
@flomonster flomonster deleted the rvs/front-fix-layers-activation-in-editor branch February 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layers are broken in editor
5 participants