front: searchrollingstock: fix rollingstock list showing loader when empty #6520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6520 +/- ##
=========================================
Coverage 28.00% 28.01%
Complexity 2167 2167
=========================================
Files 1034 1034
Lines 127683 127681 -2
Branches 2602 2602
=========================================
+ Hits 35762 35764 +2
+ Misses 90407 90403 -4
Partials 1514 1514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…empty - remove condition verifying if rollingstock list length is true - the loader is still well displayed while searching
Yohh
force-pushed
the
yoh/front-fix-empty-rollingstock-list-shows-loader
branch
from
fb4f372 to
e386971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to try it you can drop rolling_stock table and test it in a scenario or stop editoast and open the rollingstock editor
close #6013