Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix overlapping names #6487

Merged
merged 1 commit into from
Feb 1, 2024
Merged

front: fix overlapping names #6487

merged 1 commit into from
Feb 1, 2024

Conversation

Akctarus
Copy link
Contributor

closes #6444

Capture d’écran 2024-01-29 à 15 48 44 Capture d’écran 2024-01-29 à 15 44 46 Capture d’écran 2024-01-29 à 15 44 23

@Akctarus Akctarus requested a review from a team as a code owner January 29, 2024 14:53
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (e220992) 28.03% compared to head (4c0c36c) 28.03%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...ions/operationalStudies/components/BreadCrumbs.tsx 0.00% 20 Missing ⚠️
...o/components/ScenarioExplorer/ScenarioExplorer.tsx 0.00% 10 Missing ⚠️
...scenario/components/ScenarioExplorer/MiniCards.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6487      +/-   ##
============================================
- Coverage     28.03%   28.03%   -0.01%     
  Complexity     2167     2167              
============================================
  Files          1015     1015              
  Lines        127548   127572      +24     
  Branches       2584     2584              
============================================
+ Hits          35758    35760       +2     
- Misses        90296    90318      +22     
  Partials       1494     1494              
Flag Coverage Δ
core 78.56% <ø> (ø)
editoast 75.46% <ø> (+<0.01%) ⬆️
front 8.62% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.
There are small UI issues with the breadcrumb :

Capture d’écran 2024-01-30 à 15 03 50

  • one next-arrow icon is missing between the project and the study
  • the icons aren't evenly spaced between the project/study/scenario names
  • the icons (excepted the first one) are not vertically centered

@Akctarus Akctarus force-pushed the tmn/fix-overlapping-names branch 3 times, most recently from 2b21a11 to 62ea952 Compare February 1, 2024 10:15
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, everything works great, good job !

@Akctarus Akctarus force-pushed the tmn/fix-overlapping-names branch 2 times, most recently from c4b58f4 to 473926e Compare February 1, 2024 13:57
@Akctarus Akctarus force-pushed the tmn/fix-overlapping-names branch from 473926e to 4c0c36c Compare February 1, 2024 14:05
@SharglutDev SharglutDev added this pull request to the merge queue Feb 1, 2024
Merged via the queue into dev with commit 13f1502 Feb 1, 2024
21 checks passed
@SharglutDev SharglutDev deleted the tmn/fix-overlapping-names branch February 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects and studies names overlapping
3 participants