-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OperationalPointIdLocation
as location for POST /timetable/{id}
#6466
Conversation
OperationalPointIdLocation
as location for POST `/timetable/…OperationalPointIdLocation
as location for POST /timetable/{id}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6466 +/- ##
============================================
+ Coverage 28.04% 28.08% +0.03%
Complexity 2169 2169
============================================
Files 1034 1034
Lines 127757 127883 +126
Branches 2603 2603
============================================
+ Hits 35831 35913 +82
- Misses 90411 90455 +44
Partials 1515 1515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1a58765
to
4d12fe9
Compare
2fc0007
to
3a85ee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the approach.
Do you think it would be possible to write more complete tests, possibly using small_infra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test it, is there a payload which we could use to test it ?
3a85ee7
to
2115168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2115168
to
7424de2
Compare
7424de2
to
fd5f3cf
Compare
close #6182
I propose this solution since it doesn't make the backend use a SNCF extension and we doesn't have to do extra computation to extract the parts of an operational point corresponding to the uic/ch
It is improving the import when we try to respect commercial stops
+7.8%
:New stats:
Previous stats:
When we try to respect all-waypoints stats are improving too
+8.7%
:New stats:
Previous stats:
Proposal when we have TrainSchedule V2:
obj_id
is equivalent touic + ch