Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OperationalPointIdLocation as location for POST /timetable/{id} #6466

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Jan 26, 2024

close #6182

I propose this solution since it doesn't make the backend use a SNCF extension and we doesn't have to do extra computation to extract the parts of an operational point corresponding to the uic/ch

It is improving the import when we try to respect commercial stops +7.8%:
New stats:
image
Previous stats:
image

When we try to respect all-waypoints stats are improving too +8.7%:
New stats:
image
Previous stats:
image

Proposal when we have TrainSchedule V2: obj_idis equivalent to uic + ch

@bloussou bloussou changed the title Adding OperationalPointIdLocation as location for POST `/timetable/… Adding OperationalPointIdLocation as location for POST /timetable/{id} Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (472bff2) 28.04% compared to head (fd5f3cf) 28.08%.

Files Patch % Lines
editoast/src/views/timetable/import.rs 69.56% 42 Missing ⚠️
...oast/src/models/infra_objects/operational_point.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6466      +/-   ##
============================================
+ Coverage     28.04%   28.08%   +0.03%     
  Complexity     2169     2169              
============================================
  Files          1034     1034              
  Lines        127757   127883     +126     
  Branches       2603     2603              
============================================
+ Hits          35831    35913      +82     
- Misses        90411    90455      +44     
  Partials       1515     1515              
Flag Coverage Δ
core 78.54% <ø> (ø)
editoast 75.47% <63.57%> (-0.07%) ⬇️
front 8.62% <100.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bloussou bloussou force-pushed the brieuc/AddOperationalPointIdLocation branch from 1a58765 to 4d12fe9 Compare January 26, 2024 13:31
@bloussou bloussou marked this pull request as ready for review January 26, 2024 13:34
@bloussou bloussou requested a review from a team as a code owner January 26, 2024 13:34
@bloussou bloussou self-assigned this Jan 26, 2024
@bloussou bloussou added the area:editoast Work on Editoast Service label Jan 26, 2024
@bloussou bloussou force-pushed the brieuc/AddOperationalPointIdLocation branch 2 times, most recently from 2fc0007 to 3a85ee7 Compare January 26, 2024 15:01
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the approach.
Do you think it would be possible to write more complete tests, possibly using small_infra?

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

editoast/src/views/timetable/import.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it, is there a payload which we could use to test it ?

editoast/src/views/timetable/import.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/import.rs Outdated Show resolved Hide resolved
@bloussou bloussou force-pushed the brieuc/AddOperationalPointIdLocation branch from 3a85ee7 to 2115168 Compare February 2, 2024 13:22
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bloussou bloussou force-pushed the brieuc/AddOperationalPointIdLocation branch from 2115168 to 7424de2 Compare February 2, 2024 13:27
@bloussou bloussou force-pushed the brieuc/AddOperationalPointIdLocation branch from 7424de2 to fd5f3cf Compare February 2, 2024 13:29
@bloussou bloussou added this pull request to the merge queue Feb 2, 2024
Merged via the queue into dev with commit be27c8a Feb 2, 2024
22 checks passed
@bloussou bloussou deleted the brieuc/AddOperationalPointIdLocation branch February 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: operational points are incorrect on train imports
5 participants