Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: adapt pathfinding for tvm #6447

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jan 25, 2024

Ready, but waiting for #6377 to be merged

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8f490e7) 28.04% compared to head (edd8cb5) 28.06%.

Files Patch % Lines
...hfinding/constraints/SignalingSystemConstraints.kt 96.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6447      +/-   ##
============================================
+ Coverage     28.04%   28.06%   +0.01%     
- Complexity     2170     2179       +9     
============================================
  Files          1036     1037       +1     
  Lines        127980   128014      +34     
  Branches       2618     2621       +3     
============================================
+ Hits          35894    35922      +28     
- Misses        90557    90563       +6     
  Partials       1529     1529              
Flag Coverage Δ
core 78.60% <97.29%> (+0.05%) ⬆️
editoast 75.33% <ø> (-0.03%) ⬇️
front 8.64% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch 6 times, most recently from 0f77bb6 to fba9f69 Compare January 30, 2024 13:59
@anisometropie anisometropie marked this pull request as ready for review January 30, 2024 13:59
@anisometropie anisometropie requested review from a team as code owners January 30, 2024 13:59
@anisometropie anisometropie requested a review from Khoyo January 30, 2024 13:59
@anisometropie anisometropie marked this pull request as draft January 31, 2024 09:59
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed core here

@SarahBellaha SarahBellaha changed the title Sba/core/adapt pathfinding for tvm core: adapt pathfinding for tvm Feb 1, 2024
@SarahBellaha SarahBellaha linked an issue Feb 1, 2024 that may be closed by this pull request
@anisometropie anisometropie marked this pull request as ready for review February 2, 2024 11:13
@SarahBellaha SarahBellaha force-pushed the sba/core/adapt-pathfinding-for-TVM branch from fba9f69 to 18b7167 Compare February 2, 2024 11:36
@shenriotpro shenriotpro self-requested a review February 2, 2024 12:02
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the PR is now core-only

@SarahBellaha SarahBellaha force-pushed the sba/core/adapt-pathfinding-for-TVM branch from 4915f66 to 243b9ff Compare February 2, 2024 17:19
@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch from 34197fc to 60cd402 Compare February 2, 2024 18:57
@anisometropie anisometropie removed the request for review from a team February 2, 2024 19:25
@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch 2 times, most recently from 6973d78 to 465e86d Compare February 2, 2024 20:52
@Khoyo Khoyo marked this pull request as draft February 4, 2024 12:41
@Khoyo
Copy link
Contributor

Khoyo commented Feb 4, 2024

Converting to draft until it's actually working

@anisometropie anisometropie marked this pull request as ready for review February 5, 2024 11:18
@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch 3 times, most recently from 84807ba to 88843d9 Compare February 7, 2024 13:26
@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch from 88843d9 to 5139da2 Compare February 8, 2024 09:46
@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch from 5139da2 to 55c2676 Compare February 8, 2024 09:50
@anisometropie anisometropie force-pushed the sba/core/adapt-pathfinding-for-TVM branch from 55c2676 to edd8cb5 Compare February 8, 2024 12:35
@anisometropie anisometropie added this pull request to the merge queue Feb 8, 2024
Merged via the queue into dev with commit b72e96d Feb 8, 2024
22 checks passed
@anisometropie anisometropie deleted the sba/core/adapt-pathfinding-for-TVM branch February 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapting Pathfinding for TVM
4 participants