-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: adapt pathfinding for tvm #6447
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6447 +/- ##
============================================
+ Coverage 28.04% 28.06% +0.01%
- Complexity 2170 2179 +9
============================================
Files 1036 1037 +1
Lines 127980 128014 +34
Branches 2618 2621 +3
============================================
+ Hits 35894 35922 +28
- Misses 90557 90563 +6
Partials 1529 1529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0f77bb6
to
fba9f69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reviewed core here
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/constraints/SignalingSystemConstraints.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/constraints/SignalingSystemConstraints.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/constraints/SignalingSystemConstraints.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/constraints/SignalingSystemConstraints.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/fr/sncf/osrd/pathfinding/PathfindingSignalingTest.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/fr/sncf/osrd/pathfinding/constraints/SignalingSystemConstraintsTest.kt
Outdated
Show resolved
Hide resolved
fba9f69
to
18b7167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since the PR is now core-only
4915f66
to
243b9ff
Compare
34197fc
to
60cd402
Compare
6973d78
to
465e86d
Compare
Converting to draft until it's actually working |
84807ba
to
88843d9
Compare
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/constraints/SignalingSystemConstraints.kt
Outdated
Show resolved
Hide resolved
88843d9
to
5139da2
Compare
5139da2
to
55c2676
Compare
…nts for the pathfinding
55c2676
to
edd8cb5
Compare
Ready, but waiting for #6377 to be merged