Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor: fixes #6439 #6440

Merged
merged 1 commit into from
Jan 25, 2024
Merged

front: editor: fixes #6439 #6440

merged 1 commit into from
Jan 25, 2024

Conversation

jacomyal
Copy link
Contributor

Details:

  • Adds the required attribute to the composition code input so that it is red when empty
  • Adds a canSave optional function to rangeEdition/tool-factory, to allow disabling the save button when state is not correct
  • Uses the new canSave function in SpeedEditionTool to disable the save button when there are empty composition codes

Details:
- Adds the required attribute to the composition code input so that it
  is red when empty
- Adds a canSave optional function to rangeEdition/tool-factory, to
  allow disabling the save button when state is not correct
- Uses the new canSave function in SpeedEditionTool to disable the save
  button when there are empty composition codes
@jacomyal jacomyal requested a review from a team as a code owner January 25, 2024 09:49
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3650cc6) 27.72% compared to head (db805c3) 27.71%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...cations/editor/tools/rangeEdition/tool-factory.tsx 0.00% 6 Missing ⚠️
...rc/applications/editor/tools/rangeEdition/tools.ts 0.00% 5 Missing ⚠️
...eEdition/speedSection/SpeedSectionMetadataForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6440      +/-   ##
============================================
- Coverage     27.72%   27.71%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1003     1003              
  Lines        126611   126630      +19     
  Branches       2580     2580              
============================================
- Hits          35100    35095       -5     
- Misses        90021    90045      +24     
  Partials       1490     1490              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.46% <ø> (-0.03%) ⬇️
front 8.36% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@jacomyal jacomyal added this pull request to the merge queue Jan 25, 2024
Merged via the queue into dev with commit e5390a5 Jan 25, 2024
20 checks passed
@jacomyal jacomyal deleted the ajy/6439 branch January 25, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants