Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix overlapping scenario names #6433

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Akctarus
Copy link
Contributor

closes #6302
closes #6316
closes #6432

@Akctarus Akctarus requested a review from a team as a code owner January 24, 2024 11:03
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3650cc6) 27.72% compared to head (9f4f2c4) 27.71%.

Files Patch % Lines
...applications/operationalStudies/views/Scenario.tsx 0.00% 6 Missing ⚠️
...scenario/components/ScenarioExplorer/MiniCards.tsx 0.00% 3 Missing ⚠️
...o/components/ScenarioExplorer/ScenarioExplorer.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6433      +/-   ##
============================================
- Coverage     27.72%   27.71%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1003     1003              
  Lines        126611   126620       +9     
  Branches       2580     2580              
============================================
- Hits          35098    35096       -2     
- Misses        90023    90034      +11     
  Partials       1490     1490              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.47% <ø> (-0.01%) ⬇️
front 8.36% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything you did works great.
I think since we are changing those things, we could do the same for projects and studies (or you can create a new issue for that and link it to your PR) :

Capture d’écran 2024-01-24 à 17 18 48

And same suggestion for the breadcrumb in operational studies :

Capture d’écran 2024-01-24 à 17 20 22

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. The other issues will be fixed in differents PRs.

@Akctarus Akctarus added this pull request to the merge queue Jan 25, 2024
@Akctarus Akctarus changed the title front: fix scenario name overlaps front: fix overlapping scenario names Jan 25, 2024
Merged via the queue into dev with commit 8349da9 Jan 25, 2024
20 checks passed
@Akctarus Akctarus deleted the tmn/fix-overlapping-scenario-name branch January 25, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants