Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix 0 in study card #6429

Merged
merged 1 commit into from
Jan 25, 2024
Merged

front: fix 0 in study card #6429

merged 1 commit into from
Jan 25, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 23, 2024

closes #6384

Before:
image

After:
image

@clarani clarani requested a review from a team as a code owner January 23, 2024 15:32
@clarani clarani force-pushed the cni-6384-remove-0-in-study-card branch from 404d44e to fc7732c Compare January 23, 2024 15:33
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (3650cc6) 27.72% compared to head (fc7732c) 27.71%.

Files Patch % Lines
front/src/modules/study/components/StudyCard.tsx 0.00% 21 Missing ⚠️
...rc/applications/operationalStudies/views/Study.tsx 0.00% 13 Missing ⚠️
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6429      +/-   ##
============================================
- Coverage     27.72%   27.71%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1003     1003              
  Lines        126611   126624      +13     
  Branches       2580     2580              
============================================
  Hits          35098    35098              
- Misses        90023    90036      +13     
  Partials       1490     1490              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.48% <ø> (ø)
front 8.36% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested

@clarani clarani added this pull request to the merge queue Jan 25, 2024
Merged via the queue into dev with commit d065ba2 Jan 25, 2024
20 checks passed
@clarani clarani deleted the cni-6384-remove-0-in-study-card branch January 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If budget is 0 then it shouldn't be displayed
3 participants