Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix docker-compose-host.yml #6369

Merged
merged 1 commit into from
Jan 17, 2024
Merged

docker: fix docker-compose-host.yml #6369

merged 1 commit into from
Jan 17, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Jan 17, 2024

Without this, starting the containers with scripts/osrd-compose.sh fails with:

osrd-editoast | error: invalid value '%!s(int=8090)' for '--port ': invalid digit found in string

Without this, starting the containers with `scripts/osrd-compose.sh`
fails with:

osrd-editoast   | error: invalid value '%!s(int=8090)' for '--port <PORT>': invalid digit found in string
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a823c8c) 27.91% compared to head (5f4ff01) 27.66%.
Report is 7 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6369      +/-   ##
============================================
- Coverage     27.91%   27.66%   -0.26%     
  Complexity     2165     2165              
============================================
  Files          1001     1003       +2     
  Lines        126489   126505      +16     
  Branches       2580     2582       +2     
============================================
- Hits          35311    34999     -312     
- Misses        89689    90015     +326     
- Partials       1489     1491       +2     
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.72% <ø> (-0.14%) ⬇️
front 8.35% <ø> (-0.35%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm flabbergasted that this changes is required, but I guess the way of Docker is not the way of man

@Khoyo Khoyo added this pull request to the merge queue Jan 17, 2024
Merged via the queue into dev with commit dcf73de Jan 17, 2024
20 checks passed
@Khoyo Khoyo deleted the yk/fix-docker-compose-host branch January 17, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants