Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "applicable_directions" field from detectors #6290

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Remove "applicable_directions" field from detectors #6290

merged 1 commit into from
Jan 11, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jan 8, 2024

closes #6083

@hamz2a hamz2a requested review from a team as code owners January 8, 2024 16:14
@hamz2a hamz2a requested a review from Erashin January 8, 2024 16:14
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f806fd) 27.66% compared to head (cec6726) 27.65%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6290      +/-   ##
============================================
- Coverage     27.66%   27.65%   -0.02%     
  Complexity     2136     2136              
============================================
  Files           990      990              
  Lines        125883   125854      -29     
  Branches       2575     2575              
============================================
- Hits          34831    34804      -27     
+ Misses        89562    89560       -2     
  Partials       1490     1490
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.55% <100.00%> (-0.03%) ⬇️
front 8.70% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <100.00%> (-0.01%) ⬇️
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/railjson-remove-applicable-directions-field-from-detectors branch 3 times, most recently from 66c4afb to 2286b85 Compare January 8, 2024 16:43
shenriotpro
shenriotpro approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for tests/

@hamz2a hamz2a force-pushed the hai/railjson-remove-applicable-directions-field-from-detectors branch from 2286b85 to 1a5ca19 Compare January 8, 2024 16:57
flomonster
flomonster requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR overall. We could decide if keeping generated json infra is needed.

editoast/migrations/2024-01-05-092226_delete_applicable_directions_from_detectors/down.sql Outdated Show resolved Hide resolved
editoast/migrations/2024-01-05-092226_delete_applicable_directions_from_detectors/up.sql Outdated Show resolved Hide resolved
editoast/src/converters/generate_routes.rs Outdated Show resolved Hide resolved
editoast/src/converters/generate_routes.rs Show resolved Hide resolved
@flomonster flomonster changed the title railjson: remove "applicable_directions" field from detectors Remove "applicable_directions" field from detectors Jan 10, 2024
@hamz2a hamz2a force-pushed the hai/railjson-remove-applicable-directions-field-from-detectors branch from 1a5ca19 to cec6726 Compare January 11, 2024 09:20
@hamz2a hamz2a requested a review from flomonster January 11, 2024 09:30
@hamz2a hamz2a added this pull request to the merge queue Jan 11, 2024
Merged via the queue into dev with commit fe49b5b Jan 11, 2024
20 checks passed
@hamz2a hamz2a deleted the hai/railjson-remove-applicable-directions-field-from-detectors branch January 11, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenriotpro shenriotpro shenriotpro approved these changes

@flomonster flomonster flomonster approved these changes

@eckter eckter eckter approved these changes

@Erashin Erashin Awaiting requested review from Erashin Erashin was automatically assigned from osrd-project/core-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "applicable_directions" field from detectors
4 participants
@hamz2a @eckter @flomonster @shenriotpro