Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix rs traction mode update after edition in rseditor #6261

Conversation

RomainValls
Copy link
Contributor

closes #6164

@RomainValls RomainValls requested a review from a team as a code owner January 3, 2024 13:05
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (84d57c2) 27.30% compared to head (aed48da) 26.93%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...k/components/RollingStockCard/RollingStockCard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6261      +/-   ##
============================================
- Coverage     27.30%   26.93%   -0.37%     
  Complexity     2136     2136              
============================================
  Files           952      961       +9     
  Lines        124900   124258     -642     
  Branches       2690     2574     -116     
============================================
- Hits          34106    33472     -634     
- Misses        89189    89297     +108     
+ Partials       1605     1489     -116     
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.46% <ø> (+0.10%) ⬆️
front 8.69% <0.00%> (-0.79%) ⬇️
gateway 2.54% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks ! Tested ✅

@RomainValls RomainValls added this pull request to the merge queue Jan 5, 2024
Merged via the queue into dev with commit f2e96c2 Jan 5, 2024
18 of 19 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-traction-mode-update-after-edition-in-rseditor branch January 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rolling stock editor: traction summary on RS card not refreshed after edition
3 participants