-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix project/study/scenario modal closing #6231
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6231 +/- ##
============================================
- Coverage 27.89% 27.86% -0.03%
Complexity 2178 2178
============================================
Files 1041 1042 +1
Lines 127703 127848 +145
Branches 2610 2610
============================================
+ Hits 35620 35628 +8
- Misses 90552 90689 +137
Partials 1531 1531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d848771
to
9cab8fb
Compare
395111a
to
86f2667
Compare
a196492
to
cd38969
Compare
aa8fc78
to
94872a5
Compare
26e399b
to
fbf84b8
Compare
0b7bd37
to
673f413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another thing: we already have a custom hook useOutsideClick
in /utils/hooks
, can you use it and create a new hook for useInputChange
in this folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, comments only for the testing part. I'll check it again after you fixed Yoh comments
9e60e42
to
509c179
Compare
front/src/modules/scenario/components/AddOrEditScenarioModal.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/scenario/components/AddOrEditScenarioModal.tsx
Outdated
Show resolved
Hide resolved
e404f32
to
13dede3
Compare
13dede3
to
16a374b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Closes #5404