Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix project/study/scenario modal closing #6231

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Dec 28, 2023

Closes #5404

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 258 lines in your changes are missing coverage. Please review.

Comparison is base (07a977f) 27.89% compared to head (16a374b) 27.86%.

Files Patch % Lines
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% 77 Missing ⚠️
...les/scenario/components/AddOrEditScenarioModal.tsx 0.00% 66 Missing ⚠️
...dules/project/components/AddOrEditProjectModal.tsx 0.00% 51 Missing ⚠️
front/src/utils/hooks/useInputChange.ts 0.00% 22 Missing and 1 partial ⚠️
front/src/utils/hooks/useOutsideClick.ts 17.85% 23 Missing ⚠️
.../applications/operationalStudies/views/Project.tsx 0.00% 5 Missing ⚠️
...applications/operationalStudies/views/Scenario.tsx 0.00% 5 Missing ⚠️
...rc/applications/operationalStudies/views/Study.tsx 0.00% 2 Missing ⚠️
.../editor/components/InfraErrors/InfraErrorsList.tsx 0.00% 1 Missing ⚠️
...ns/rollingStockEditor/views/RollingStockEditor.tsx 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6231      +/-   ##
============================================
- Coverage     27.89%   27.86%   -0.03%     
  Complexity     2178     2178              
============================================
  Files          1041     1042       +1     
  Lines        127703   127848     +145     
  Branches       2610     2610              
============================================
+ Hits          35620    35628       +8     
- Misses        90552    90689     +137     
  Partials       1531     1531              
Flag Coverage Δ
core 79.38% <ø> (ø)
editoast 75.27% <ø> (-0.01%) ⬇️
front 8.41% <2.27%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 3 times, most recently from d848771 to 9cab8fb Compare January 3, 2024 13:19
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 2 times, most recently from 395111a to 86f2667 Compare January 15, 2024 14:53
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 2 times, most recently from a196492 to cd38969 Compare January 24, 2024 16:35
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 3 times, most recently from aa8fc78 to 94872a5 Compare February 2, 2024 01:12
@Akctarus Akctarus marked this pull request as ready for review February 2, 2024 08:32
@Akctarus Akctarus requested a review from a team as a code owner February 2, 2024 08:32
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 11 times, most recently from 26e399b to fbf84b8 Compare February 7, 2024 15:07
@Akctarus Akctarus changed the title front: fix modal closing and add focus on name front: fix project/study/scenario modal closing Feb 7, 2024
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch from 0b7bd37 to 673f413 Compare February 7, 2024 16:39
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💪

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another thing: we already have a custom hook useOutsideClick in /utils/hooks, can you use it and create a new hook for useInputChange in this folder?

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, comments only for the testing part. I'll check it again after you fixed Yoh comments

@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 3 times, most recently from 9e60e42 to 509c179 Compare February 9, 2024 09:19
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch 2 times, most recently from e404f32 to 13dede3 Compare February 12, 2024 10:36
@Akctarus Akctarus force-pushed the tmn/fix-project-creation-modal branch from 13dede3 to 16a374b Compare February 12, 2024 10:44
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SharglutDev SharglutDev added this pull request to the merge queue Feb 12, 2024
Merged via the queue into dev with commit 5d00ea2 Feb 12, 2024
22 checks passed
@SharglutDev SharglutDev deleted the tmn/fix-project-creation-modal branch February 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: ux: project creation modal (scenario or study) closes immediately when clicked next to
3 participants