front: search op with ci - ch code

[SarahBellaha]

• Front part of this issue
• Quick refacto of the InputSNCF component.

[codecov]

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (37aac79) 27.72% compared to head (2cf5ea0) 27.71%.
Report is 2 commits behind head on dev.

Files	Patch %	Lines
front/src/common/BootstrapSNCF/InputSNCF.tsx	7.01%	53 Missing ⚠️
front/src/common/Map/Search/MapSearchStation.tsx	0.00%	51 Missing and 1 partial ⚠️
front/src/common/Map/utils.ts	0.00%	12 Missing ⚠️
front/src/common/Map/Search/MapSearchLine.tsx	0.00%	8 Missing ⚠️
front/src/common/Map/Search/MapSearchSignal.tsx	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #6204      +/-   ##
============================================
- Coverage     27.72%   27.71%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1003     1003              
  Lines        126611   126622      +11     
  Branches       2580     2580              
============================================
- Hits          35099    35093       -6     
- Misses        90022    90039      +17     
  Partials       1490     1490              

Flag	Coverage Δ
core	78.58% <ø> (ø)
editoast	75.44% <ø> (-0.05%)	⬇️
front	8.37% <2.98%> (+<0.01%)	⬆️
gateway	2.50% <ø> (ø)
railjson_generator	87.44% <ø> (ø)
tests	81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clarani]

Almost good for me, just found 1 bug. If I clear the inputs, then a bad request is launched. It also happens when I open the modal

[SharglutDev]

Thank you for your PR, left some comments.

Maybe it can be done in a separated refacto for the Input component but I think it's strange to have a clearButton props and an onClear props. As they work together, they should be merged in a single one (or we keep only the onClear one).
Moreover, we have a lot of default values for optional props but they are not needed.

[clarani]

Nice PR ! Left some comments :)
The bug has been solved ✅

[SharglutDev]

Lgtm and tested, good job, great util function :)

[clarani]

Very nice PR, LGTM and tested ✅