Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error reporting to timetable import #6161

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Add error reporting to timetable import #6161

merged 4 commits into from
Jan 19, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Dec 19, 2023

Fixes #5853

@Khoyo Khoyo added kind:feature-task Work related to a feature epic area:editoast Work on Editoast Service labels Dec 19, 2023
@Khoyo Khoyo self-assigned this Dec 19, 2023
@Khoyo Khoyo force-pushed the yk/timetable-import-errors branch from 7660a6a to 35a2737 Compare December 19, 2023 12:56
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 253 lines in your changes are missing coverage. Please review.

Comparison is base (fac9976) 27.70% compared to head (0a30d8c) 27.77%.

Files Patch % Lines
editoast/src/views/timetable/import.rs 34.20% 252 Missing ⚠️
...oast/src/models/infra_objects/operational_point.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6161      +/-   ##
============================================
+ Coverage     27.70%   27.77%   +0.07%     
  Complexity     2165     2165              
============================================
  Files          1002     1003       +1     
  Lines        126258   126467     +209     
  Branches       2580     2580              
============================================
+ Hits          34978    35131     +153     
- Misses        89790    89846      +56     
  Partials       1490     1490
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.68% <34.79%> (-0.07%) ⬇️
front 8.37% <100.00%> (+0.02%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <100.00%> (+0.01%) ⬆️
tests 82.01% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo force-pushed the yk/timetable-import-errors branch from 0ca56e4 to a0b7fe6 Compare December 19, 2023 16:52
@shenriotpro
Copy link
Contributor

Hi, what's the status here? It looks like this would be very useful for the next batch of imports.

@Khoyo Khoyo force-pushed the yk/timetable-import-errors branch 3 times, most recently from 1ef7fcf to d8474a6 Compare January 17, 2024 08:44
@Khoyo Khoyo marked this pull request as ready for review January 17, 2024 08:45
@Khoyo Khoyo requested a review from a team as a code owner January 17, 2024 08:45
flomonster
flomonster reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this PR is heading seems correct to me

@Khoyo Khoyo force-pushed the yk/timetable-import-errors branch from d8474a6 to 76c488a Compare January 18, 2024 06:36
@Khoyo Khoyo requested a review from a team as a code owner January 18, 2024 06:36
@Khoyo Khoyo force-pushed the yk/timetable-import-errors branch 4 times, most recently from c6d1544 to a96c8da Compare January 18, 2024 10:47
shenriotpro
shenriotpro approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

tests/tests/test_timetable.py Outdated Show resolved Hide resolved
leovalais
leovalais approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

editoast/src/views/pathfinding/mod.rs Show resolved Hide resolved
editoast/src/views/timetable/import.rs Outdated Show resolved Hide resolved
@Khoyo Khoyo force-pushed the yk/timetable-import-errors branch from a0f92c7 to 0a30d8c Compare January 19, 2024 15:18
@Khoyo Khoyo enabled auto-merge January 19, 2024 15:19
@Khoyo Khoyo added this pull request to the merge queue Jan 19, 2024
Merged via the queue into dev with commit 572a549 Jan 19, 2024
20 checks passed
@Khoyo Khoyo deleted the yk/timetable-import-errors branch January 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster left review comments

@shenriotpro shenriotpro shenriotpro approved these changes

@leovalais leovalais leovalais approved these changes

@eckter eckter eckter approved these changes

Assignees

@Khoyo Khoyo

Labels
area:editoast Work on Editoast Service kind:feature-task Work related to a feature epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: Post /timetable/{timetable_id} does not return any content or summary of success or failure
5 participants
@Khoyo @shenriotpro @eckter @flomonster @leovalais