Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editoast ci code to operational point search #6145

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Dec 18, 2023

A sneaky inconsistency was introduced with the Search derive macro: the table search_operationalpoint became search_operational_point but the tiggers on the infra_obejct table were not updated to include the _.

@leovalais leovalais added the area:editoast Work on Editoast Service label Dec 18, 2023
@leovalais leovalais requested a review from clarani December 18, 2023 15:15
@leovalais leovalais self-assigned this Dec 18, 2023
@leovalais leovalais requested a review from a team as a code owner December 18, 2023 15:15
@leovalais leovalais force-pushed the lva/op-search-ci-code branch from 381ee83 to f810be0 Compare December 18, 2023 15:21
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only reviewed / not tested)

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e3b89a8) 26.63% compared to head (bad710c) 26.63%.
Report is 3 commits behind head on dev.

Files Patch % Lines
editoast/src/tables.rs 0.00% 4 Missing ⚠️
editoast/src/views/search/search_object.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6145      +/-   ##
============================================
- Coverage     26.63%   26.63%   -0.01%     
  Complexity     2123     2123              
============================================
  Files           930      930              
  Lines        123359   123363       +4     
  Branches       2677     2677              
============================================
- Hits          32857    32856       -1     
- Misses        88916    88921       +5     
  Partials       1586     1586              
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.93% <0.00%> (-0.02%) ⬇️
front 9.36% <100.00%> (-0.01%) ⬇️
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/op-search-ci-code branch 5 times, most recently from 7a6c048 to 09eda5b Compare December 19, 2023 13:14
@leovalais leovalais force-pushed the lva/op-search-ci-code branch from 09eda5b to bad710c Compare December 19, 2023 13:31
@leovalais leovalais requested a review from flomonster December 19, 2023 13:42
@flomonster flomonster changed the title editoast: add ci code to operational point search Add editoast ci code to operational point search Dec 19, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Dec 19, 2023
Merged via the queue into dev with commit bcf6747 Dec 19, 2023
18 checks passed
@leovalais leovalais deleted the lva/op-search-ci-code branch December 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants