Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix text zoom on GET #6123

Merged
merged 1 commit into from
Dec 14, 2023
Merged

front: fix text zoom on GET #6123

merged 1 commit into from
Dec 14, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 14, 2023

closes #6081

@clarani clarani requested a review from a team as a code owner December 14, 2023 15:01
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (66a103d) 26.58% compared to head (fc12b13) 26.58%.

Files Patch % Lines
...lt/components/ChartHelpers/enableInteractivity.tsx 0.00% 6 Missing ⚠️
...mulationResult/components/ChartHelpers/drawText.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6123      +/-   ##
============================================
- Coverage     26.58%   26.58%   -0.01%     
  Complexity     2123     2123              
============================================
  Files           931      931              
  Lines        123165   123171       +6     
  Branches       2678     2678              
============================================
  Hits          32741    32741              
- Misses        88837    88843       +6     
  Partials       1587     1587              
Flag Coverage Δ
core 78.96% <ø> (ø)
editoast 74.70% <ø> (ø)
front 9.37% <0.00%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani enabled auto-merge December 14, 2023 16:03
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job :)

@clarani clarani added this pull request to the merge queue Dec 14, 2023
Merged via the queue into dev with commit 44ec439 Dec 14, 2023
18 checks passed
@clarani clarani deleted the cni-6081-text-zoom-get branch December 14, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: zoom on train name on the GET is too big
4 participants