-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: make indicator disappear after onclick event on the map #6104
Conversation
ce10416
to
efef27a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6104 +/- ##
============================================
+ Coverage 26.56% 26.57% +0.01%
Complexity 2123 2123
============================================
Files 931 930 -1
Lines 123272 123294 +22
Branches 2678 2677 -1
============================================
+ Hits 32744 32771 +27
+ Misses 88941 88937 -4
+ Partials 1587 1586 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and all this files refacto !
Tested and everything works. Before approve, should we clarify if clicking on map is what we want to remove the marker ? @axrolld @thibautsailly
68cb68b
to
cb654c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. Left one more comment.
I also think that, as we have the possibility to search in the SimulationResultsMap, we should also be able to remove the blue indicator with the same behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm ! (don't forget to squash)
d1b56a2
to
ffcac61
Compare
Close #5588