Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: make indicator disappear after onclick event on the map #6104

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

SarahBellaha
Copy link
Contributor

Close #5588

@SarahBellaha SarahBellaha requested a review from a team as a code owner December 11, 2023 21:02
@SarahBellaha SarahBellaha force-pushed the sba/front/add-timeout-on-blue-indicator branch from ce10416 to efef27a Compare December 11, 2023 21:05
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 185 lines in your changes are missing coverage. Please review.

Comparison is base (5bf07ec) 26.56% compared to head (ffcac61) 26.57%.
Report is 8 commits behind head on dev.

Files Patch % Lines
front/src/applications/editor/Map.tsx 0.00% 43 Missing and 1 partial ⚠️
front/src/applications/editor/Editor.tsx 0.00% 28 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 25 Missing ⚠️
front/src/applications/referenceMap/Map.tsx 0.00% 20 Missing ⚠️
front/src/common/Map/Search/MapSearchLine.tsx 0.00% 13 Missing ⚠️
front/src/common/Map/Search/MapSearchSignal.tsx 0.00% 12 Missing ⚠️
front/src/common/Map/Search/MapSearch.tsx 0.00% 9 Missing and 1 partial ⚠️
front/src/common/Map/Search/MapSearchStation.tsx 0.00% 9 Missing ⚠️
front/src/common/Map/utils.ts 0.00% 5 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6104      +/-   ##
============================================
+ Coverage     26.56%   26.57%   +0.01%     
  Complexity     2123     2123              
============================================
  Files           931      930       -1     
  Lines        123272   123294      +22     
  Branches       2678     2677       -1     
============================================
+ Hits          32744    32771      +27     
+ Misses        88941    88937       -4     
+ Partials       1587     1586       -1     
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.76% <ø> (+0.06%) ⬆️
front 9.37% <0.00%> (-0.01%) ⬇️
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and all this files refacto !

Tested and everything works. Before approve, should we clarify if clicking on map is what we want to remove the marker ? @axrolld @thibautsailly

front/src/applications/editor/Map.tsx Outdated Show resolved Hide resolved
@SarahBellaha SarahBellaha force-pushed the sba/front/add-timeout-on-blue-indicator branch 4 times, most recently from 68cb68b to cb654c7 Compare December 15, 2023 10:55
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. Left one more comment.

I also think that, as we have the possibility to search in the SimulationResultsMap, we should also be able to remove the blue indicator with the same behavior

front/src/applications/editor/Map.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ! (don't forget to squash)

@SarahBellaha SarahBellaha force-pushed the sba/front/add-timeout-on-blue-indicator branch from d1b56a2 to ffcac61 Compare December 15, 2023 14:00
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 15, 2023
Merged via the queue into dev with commit a99e890 Dec 15, 2023
19 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/add-timeout-on-blue-indicator branch December 15, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blue indicator remains after searching for a remarkable point
2 participants