Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: return error when allowance ranges are out of bounds #6093

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Dec 11, 2023

closes #4841

@hamz2a hamz2a requested a review from a team as a code owner December 11, 2023 10:33
@hamz2a hamz2a requested a review from eckter December 11, 2023 10:33
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (746bfcc) 26.55% compared to head (aa67657) 26.54%.
Report is 16 commits behind head on dev.

Files Patch % Lines
...pe_sim/allowances/AbstractAllowanceWithRanges.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6093      +/-   ##
============================================
- Coverage     26.55%   26.54%   -0.01%     
- Complexity     2117     2123       +6     
============================================
  Files           931      931              
  Lines        122904   123061     +157     
  Branches       2670     2678       +8     
============================================
+ Hits          32633    32667      +34     
- Misses        88693    88807     +114     
- Partials       1578     1587       +9     
Flag Coverage Δ
core 78.96% <50.00%> (-0.01%) ⬇️
editoast 74.66% <ø> (-0.01%) ⬇️
front 9.32% <ø> (+<0.01%) ⬆️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/core-crashes-when-allowance-ranges-are-out-of-bounds branch 2 times, most recently from 833d8cf to 9f8f09b Compare December 12, 2023 09:02
@hamz2a hamz2a force-pushed the hai/core-crashes-when-allowance-ranges-are-out-of-bounds branch from 9f8f09b to aa67657 Compare December 12, 2023 09:04
@hamz2a hamz2a added this pull request to the merge queue Dec 12, 2023
Merged via the queue into dev with commit 1782427 Dec 12, 2023
17 checks passed
@hamz2a hamz2a deleted the hai/core-crashes-when-allowance-ranges-are-out-of-bounds branch December 12, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend crashes when allowance ranges are out of bounds
2 participants