front:sdm: align things in sillons menus #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6073 +/- ##
============================================
- Coverage 26.55% 26.54% -0.01%
- Complexity 2117 2123 +6
============================================
Files 931 931
Lines 122901 123067 +166
Branches 2670 2678 +8
============================================
+ Hits 32633 32674 +41
- Misses 88690 88806 +116
- Partials 1578 1587 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Thank you for your PR. Left some comments.
Even though it wasn't ask in the issue (which seems already solved in both asked parts), I agree with your alignments changes, but you should double check with the UX, @thibautsailly, if all these changes are what he wants.
Also if you could rename your commit with front: stdcm... (you missed the 't' in stdcm)
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/stdcmAllowances/components/StdcmAllowances.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/stdcmAllowances/components/StdcmAllowances.tsx
Outdated
Show resolved
Hide resolved
tykayn
force-pushed
the
ble/fix-margins-between-icons-and-labels
branch
from
c141f21 to
a1c1701
Compare
SharglutDev
requested changes
Dec 11, 2023
tykayn
force-pushed
the
ble/fix-margins-between-icons-and-labels
branch
from
a1c1701 to
e6bc9e8
Compare
SharglutDev
approved these changes
Dec 11, 2023
tykayn
force-pushed
the
ble/fix-margins-between-icons-and-labels
branch
from
e6bc9e8 to
43add1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4481
#4481
changes some margins and padding in elements of the lateral bar of the sillons reservation page
