-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix track section length when editing geometry #6017
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6017 +/- ##
============================================
- Coverage 26.91% 26.90% -0.02%
Complexity 2139 2139
============================================
Files 932 932
Lines 123836 123970 +134
Branches 2690 2689 -1
============================================
+ Hits 33336 33351 +15
- Misses 88894 89014 +120
+ Partials 1606 1605 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3b5f924
to
0fddb32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have a bug. When editing a track section with slopes, changing the geometry results in an invalid position in slopes (negative values).
d245d8f
to
e2016ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this fix 🎉 (Tested, not reviewed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
front/src/applications/editor/components/LinearMetadata/FormComponent.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/components/LinearMetadata/FormComponent.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/components/LinearMetadata/FormComponent.tsx
Outdated
Show resolved
Hide resolved
front/src/common/BootstrapSNCF/FormSNCF/DebouncedNumberInputSNCF.tsx
Outdated
Show resolved
Hide resolved
front/src/common/BootstrapSNCF/FormSNCF/DebouncedNumberInputSNCF.tsx
Outdated
Show resolved
Hide resolved
front/src/common/BootstrapSNCF/FormSNCF/DebouncedNumberInputSNCF.tsx
Outdated
Show resolved
Hide resolved
1f87a82
to
94b7bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! You just need to squash your commits :) Thanks ✅
fc83a48
to
805c8f6
Compare
805c8f6
to
9b7a22b
Compare
9b7a22b
to
8a73067
Compare
8a73067
to
149d383
Compare
Closes #5933
Implementation of a new behavior: when a track section is created, length can be edited directly on the map, but when a length is already entered, the drag must not affect the length.